search

altmetric / embiggen

A Ruby library to expand shortened URLs
https://rubygems.org/gems/embiggen
MIT License
124 stars 6 forks source link

Update list of shorteners #18

Closed ascastro closed 8 years ago

ascastro commented 8 years ago

Add ja.ma to the list.

mudge commented 8 years ago

Discussed over Slack but this might be a good case for passing a custom list of shorteners in the client application rather than having to patch Embiggen every time we want to change the list.

jbilbo commented 8 years ago

It's OK to use the custom list to have a fast way to use a shortener not already supported, but it would be a good practice to add it to embiggen as a PR, and from time to time release patches to keep the list updated. Otherwise we might end up having a different non-matching lists per applications, much harder to maintain.

mudge commented 8 years ago

As http://ja.ma is a branded Bitly short domain, is it worth adding a more complete list of branded domains (e.g. from http://vanityurlshorteners.com/) to justify a patch release?