altmetric / embiggen

A Ruby library to expand shortened URLs
https://rubygems.org/gems/embiggen
MIT License
124 stars 6 forks source link

Update addressable gem #35

Closed idlebot closed 6 years ago

idlebot commented 6 years ago

Hello, would you mind making addressable gem version a little bit more flexible?

Instead of:

  s.add_dependency('addressable', '~> 2.3')

allow anything between 2.3 and 3.0

  s.add_dependency('addressable', '~> 2', '>= 2.3')

I need this because a lot of the Google Cloud SDK gems use version 2.5 and above.

shamess commented 6 years ago

Hey idlebot,

~> 2.3 means "at least 2.3, and anything up to (and not including) 3.0. So, you shouldn't be seeing any issues when trying to use addressable 2.5. In our private projects, we're actually using it with 2.4 without issue.

Which gem are you finding incompatible? We can play around on our side to double check it, if you like.

idlebot commented 6 years ago

You're right, it was something else on my project that was causing it not to update. Sorry about that.