Return original URL if host is unreachable

altmetric / embiggen

A Ruby library to expand shortened URLs

https://rubygems.org/gems/embiggen

MIT License

124 stars 6 forks source link

Return original URL if host is unreachable #5

Closed omartell closed 9 years ago

omartell commented 9 years ago

As embiggen handles Timeout::Error and Errno::ECONNRESET, was wondering if it should also handle Errno::EHOSTUNREACH and return the original URL.

omartell commented 9 years ago

It might also be worth rescuing Errno::TIMEDOUT.

mudge commented 9 years ago

If we switch to the API in #3, we could rescue all descendants of StandardError rather than having to play whack a mole with the various exception types that could be raised by Net::HTTP.

omartell commented 9 years ago

Makes sense, let's not get into exceptions "guacamole".

On Wed, Apr 22, 2015 at 7:55 PM, Paul Mucur notifications@github.com wrote:

If we switch to the API in #3, we could rescue all descendants of StandardError rather than having to play whack a mole with the various exception types that could be raised by Net::HTTP.

Reply to this email directly or view it on GitHub: https://github.com/altmetric/embiggen/issues/5#issuecomment-95301829

mudge commented 9 years ago

Fixed in 0.1.1.

altmetric / embiggen

Return original URL if host is unreachable #5

If we switch to the API in #3, we could rescue all descendants of StandardError rather than having to play whack a mole with the various exception types that could be raised by Net::HTTP.

If we switch to the API in #3, we could rescue all descendants of `StandardError` rather than having to play whack a mole with the various exception types that could be raised by `Net::HTTP`.