Allow other HTTP clients to be used

altmetric / embiggen

A Ruby library to expand shortened URLs

https://rubygems.org/gems/embiggen

MIT License

124 stars 6 forks source link

Allow other HTTP clients to be used #9

Open mudge opened 9 years ago

mudge commented 9 years ago

Embiggen currently uses Ruby's standard Net::HTTP library to perform HTTP requests but this is not open for extension (e.g. to configure proxies or swap out entirely). It might be better to provide an adapter interface for other HTTP client libraries.

dentarg commented 8 years ago

I guess this, if implemented, would expose the ability to change the User-Agent used by embiggen, right?

mudge commented 8 years ago

Yes: if we allowed users to access (and even provide) the HTTP client itself, then they could configure it however they wish (e.g. proxy settings).