Some serverside vehicle setters not working correctly

[C0kkie]

Client/server version

Build #dev/2.1-dev65, branch dev

Current behavior

• [ ] setWindowOpened - false state doesnt work for remote players until restream

• [ ] setWindowDamaged - doesnt work at all, also not on restream

• [ ] setWheelHealth - Once used, the wheels get fixed on netOwner change, otherwise the setter works (checked with the getter)

• [ ] setWheelHasTire

• [ ] setWheelDetached - works if you are in range, if you restream they are attached again, false isnt working if you are in range

• [ ] setSpecialLightDamaged - works in range, if you restream they are fixed again

• [ ] setPartDamageLevel - not working

• [ ] setPartBulletHoles - working in range for non net owner | if you restream its resettet

• [ ] setLightDamaged - working in range | on restream its resettet (if more then 1 are damaged) | isDamaged false doesnt work if it was damaged

• [ ] setDoorState

  • 0 closes the door instantly for netOwner, smoothly for remote player
  • 0 makes the door not closable by driving sometimes
  • netOwner doesnt seem to have the correct doorState compared to the remote players
  • sometimes states are just wrong (5 opens the door just a bit for example and you have to call the method a second time to have the right opening state

• [ ] setBumperDamageLevel - doesnt work at all

• [ ] setArmoredWindowShootCount - doesnt work

• [ ] setArmoredWindowHealth - doesnt work

• [ ] Vehicle.dirtLevel property always return 0 or 41 and setter problem (https://github.com/altmp/altv-issues/issues/372)

• [ ] Native setVehicleNitroEnabled not working as it used to (https://github.com/altmp/altv-issues/issues/604)

• [ ] Make slipstream settable per vehicle, fix visuals, make boost customizable (https://github.com/altmp/altv-issues/issues/599)

• [x] Native setVehicleLights is not synced

• [ ] Sync setVehicleIndicatorLights native function

• [ ] Sync setVehicleSearchlight native function https://github.com/altmp/altv-issues/issues/337

• [ ] Sync setVehicleHasMutedSirens native function

• [ ] Vehicle.EngineOn & ManualEngineControl getter/setter sync issue

  • When you set engineOn = false while in driver seat the player turns ON the engine, and then engineOn = false doesnt work anymore as if the server state was on false, once you move the car the state got synced and engineOn works again
    • manualEngineControl works when entering the vehicle, but as soon as you press W the engine starts, probably missing another flag

• [ ] Ability to change vehicle rpm

• [ ] Add vehicle bulletproof tyres property (https://github.com/altmp/altv-issues/issues/600)

Also if you shoot a window like this: https://img.c0kkie.de/c0kkie_08-12-2020_23-52-49.jpg And you restream the window is totally broken https://img.c0kkie.de/c0kkie_08-12-2020_23-53-02.jpg

[FDiskas]

Please also check getDoorState method vehicle.getDoorState(doorIndex); always returns 0

[17:48:44] {"doorIndex":5,"doorState":0}
[17:49:51] {"doorIndex":2,"doorState":0}
[17:50:23] {"doorIndex":1,"doorState":0}

[FDiskas]

Also there is more getters not working

• [ ] handbrakeActive
• [x] lockState
• [x] engineOn
• [ ] getDoorState

[Kingwolfi]

I did some tests and the vehicle.SetDoorState only works for no netowner players but not for the netowner (RPC Error). The other result is if a door is open and the netowner walks away and stream back in the vehicle the door is closed. If another player is in range of the vehicle the netowner is changed to this one and the doors are open if you stream in the vehicle. there is something wrong with the netowner handling.

If you use this code the doorstate changes also for the netowner but afterwards the sync is bad (just a test) vehicle.SetNetworkOwner(null); vehicle.SetDoorState(door, state);

[FabianTerhorst]

Test the wheel setters again in 11.0-dev21

[Yiin]

getDoorState does seem to work fine for doors, but bonnet and trunk (door id 4 and 5) still always return 0 for some vehicles, namely rebel, rebel2, bodhi2, probably some others with similar trunks/bonnets.

[nacelol]

getDoorState does seem to work fine for doors, but bonnet and trunk (door id 4 and 5) still always return 0 for some vehicles, namely rebel, rebel2, bodhi2, probably some others with similar trunks/bonnets.

Yeah, still relevant today. This seems to be the problem in all vehicles that have only 2 seats (e.g. sultanrs, winky)