altmp / altv-js-module

JS module for alt:V Multiplayer. Powered by NodeJS & v8
MIT License
54 stars 36 forks source link

shared: Add support for nested object and array logging #129 #180

Closed vanlueckn closed 2 years ago

vanlueckn commented 2 years ago

Related to #129

Reimplements the V8Helpers::Stringify method for logging nested arrays and objects.

Before: [object Object],1,2,3

After: [{a: 10}, 1, 2, 3]

xxshady commented 2 years ago

@vanlueckn We don't need implementation in c++ anymore, i already ported util inspect from nodejs #170 and we will use it for logging

vanlueckn commented 2 years ago

I think that this is a good thing anyway

LeonMrBonnie commented 2 years ago

This is horrible for performance, I already thought about doing it like that before, but it was too bad for performance. We don't need this anyway once #170 is merged