search

altmp / altv-types

Type definitions for the alt:V JavaScript modules.
https://www.npmjs.com/~vadzz
MIT License
31 stars 74 forks source link

server: Fix Ped.armour spelling #280

Closed edgarasx closed 11 months ago

deluvas1911 commented 11 months ago

https://github.com/altmp/altv-js-module/blob/dev/server/src/bindings/Player.cpp#L1420 it's called armour in the js-module. just randomly changing the name in the types, which would also be a huge breaking change, won't change anything

edgarasx commented 11 months ago

https://github.com/altmp/altv-js-module/blob/dev/server/src/bindings/Player.cpp#L1420 it's called armour in the js-module. just randomly changing the name in the types, which would also be a huge breaking change, won't change anything

https://github.com/altmp/altv-js-module/blob/a6bb1914cc55865909fc09fc25c536be66883d3d/server/src/bindings/Ped.cpp#L79C66-L79C66

I'm talking about Peds class, not Players class. It is correctly spelled as armour in js-module and incorrectly spelled as amour in typings.

deluvas1911 commented 11 months ago

Ah, then good point.Sorry, my oversight @C0kkie