altmp / altv-types

Type definitions for the alt:V JavaScript modules.
https://www.npmjs.com/~vadzz
MIT License
29 stars 73 forks source link

Return type problem #313

Closed uiuytb closed 1 month ago

uiuytb commented 2 months ago

Hello,

I don't know if I misunderstood how rpc types works but should not the return type of the onRpc be Promise<ReturnType<shared.ICustomServerClientRpc[K]>> | ReturnType<shared.ICustomServerClientRpc[K]>) and not Promise<ReturnType<shared.ICustomClientServerRpc[K]>> | ReturnType<shared.ICustomClientServerRpc[K]>) in the client module ?

It's at line 2612: https://github.com/altmp/altv-types/blob/885493e2ea0612b492815f1124dfa57ba1cb37d2/client/index.d.ts#L2612

xxshady commented 1 month ago

sorry for ignoring, gonna fix that