search

altmp / coreclr-module

CoreClr (.NET Core Common Language Runtime) community made module
MIT License
15 stars 7 forks source link

[Release branch] Latest changes breaks client-side code if AltV.Client NuGet has no latest version #13

Closed M1raclee closed 5 months ago

M1raclee commented 5 months ago

About 20h ago AltV.Client get's an update and it's broken signature of methods (or something similar) of client-side.

Client-side error: image

Code with error line: _webView.On<string>("browser:ready", OnBrowserDomReady);

Previous AltV.Net.Client version: 16.0.11 New AltV.Net.Client version: 16.0.12

It fixed easy with update client-side NuGet and now it's not a problem for me, but it seems like a problem, when my server will be in production and similar update will be released, that breaks all my users (client-side) before I update NuGet and recompile client-side code.

It happens not a first time, few weeks ago was similar problem on dev branch (wrote about it in discord)

Is it possible to prevent the same situation in the future to give a time to update? (Maybe some alerts in discord channel about "breaks" changes, because update log didn't get any notification about it on release branch)

Doxoh commented 5 months ago

can u check ur client-log, whats got logged, as loading nuget version?

M1raclee commented 5 months ago 
[21:25:03] Resolving AltV.Net.Client.Async
[21:25:03] Resolving AltV.Net.Client
[21:25:03] Trying to load from cache
[21:25:03] Resolving ***
[21:25:03] Resolving AltV.Net.Shared
[21:25:03] Trying to load from cache
[21:25:03] Resolving AltV.Net.CApi
[21:25:03] Trying to load from cache
[21:25:03][Warning] Found mismatching SDK methods. Please update AltV.Net.Client NuGet.
[21:25:04] Core initialized
[21:25:04] Delegates set
[21:25:04] Resolving ***
[21:25:04] Resolving ***
[21:25:04] Resolving ***
[21:25:04]  
[21:25:04]   
[21:25:04]    
[21:25:04] =========[21:25:04]========
[21:25:04][Error] [Error]: Exception: System.MissingMethodException: Method not found: 'Void AltV.Net.Client.Alt.On(AltV.Net.Client.Elements.Interfaces.IWebView, System.String, System.Action`1<!!0>)'.
Doxoh commented 5 months ago

Void AltV.Net.Client.Alt.On( are no longer exists. its got fixed, sorry for the breaking change.

its now returing the function, for the Alt.Off event