search

altsan / os2-estyler

Styler (eStyler) for OS/2
GNU General Public License v3.0
3 stars 1 forks source link

Missing/conflicting mnemonics #4

Open LewisR opened 7 years ago

LewisR commented 7 years ago

Help button is missing mnemonic. Titlebar page 1: Text alignment (a) conflicts with Apply Titlebar page 2/3: Swap colors (s) conflicts with Show the titlebar border Titlebar page 2/3: Swap colors (s) conflicts with Text shadow Titlebar page 2/3: Swap colors buttons all use (s) Titlebar page 2/3: Text shadow color (h) will conflict with Help Titlebar page 2/3: Type of background (t) conflicts with Text color Button: Pushbutton enhancements (p) conflicts with Preview Button: 3D style disabled buttons (d) conflicts with Default Button: Add a new image... (a) conflicts with Apply

System shutdown object:

Help button is missing mnemonic. Shutdown: Shut down (d) conflicts with Default Shutdown - timing options: WinShutdownSystem (h) will conflict with Help Reboot: Allow to reboot the following volumes (a) conflicts with Add and Apply Reboot: Find button is missing mnemonic (and ellipsis) Programs: Run the following programs on shutdown (r) conflicts with Remove Programs: Add (a) conflicts with Apply Termination list: Add (a) conflicts with Apply

Windows keys object:

Help button is missing mnemonic.

altsan commented 7 years ago

Buttons with existing hotkeys don't normally receive mnemonics. These include OK (Enter), Cancel (Esc) and Help (F1).

I've adjusted several of the others. However it's pretty much impossible to avoid them all (especially some since strings, mnemonics included, are used for multiple controls). I'll point out that duplicate mnemonics aren't actually a bug, just something that it's recommended to try and avoid as much as possible.

LewisR commented 7 years ago

Ah...

Well, I know you mentioned to me about OK and Cancel. I hadn't included Help in that mix (the tax software we're using this year - Windoze - is absolutely without respect for any of this; F10 brings up the calculator, and F1 pastes from it into the field in the input screen...egad).

Also, I think I saw Help with a mnemonic somewhere in the UI.

Finally, I kind of opened this ticket as a reminder to me, as I was going to fix this stuff as best I could. I didn't want you to have to bother with it. ;-)

Help pages are almost done, too (OT for this ticket, but as I was working on those, I took a close look at the UI, which led me here).

LewisR commented 7 years ago

Here's the inconsistency: OK and Cancel have mnemonics on the Shutdown - timing options panel (which for some reason isn't implemented as a second page behind the main Shutdown page, and instead is the only such popup page in the entire app - I know: it's the advanced options page), but there, Help does not. These are fine points, and I'm not trying to be argumentative. This is just a thought exercise. :-)