gitu fails to open $EDITOR when $EDITOR contains cli arguments

altsem / gitu

A TUI Git client inspired by Magit

MIT License

1.7k stars 88 forks source link

gitu fails to open $EDITOR when $EDITOR contains cli arguments #112

Closed fs111 closed 4 months ago

fs111 commented 4 months ago

On my work mac I have $EDITOR set to /Applications/MacVim.app/Contents/MacOS/Vim -v which is MacVim. gitu does not understand this correctly because it assumes that the content of $EDITOR is a path to an executable and nothing else. It should parse this content properly and invoke the command correctly.

altsem commented 4 months ago

Ty for reporting this! I just released 0.13.1 with a fix (found in efc7e32d9e2e63d1e8b9eeeea39d9ee2e92c3b50). I improved the way line:col args are passed as well, hopefully it'll work :)