search

altsem / gitu

A TUI Git client inspired by Magit
MIT License
1.66k stars 87 forks source link

Windows build #142

Closed johnd0e closed 2 months ago

johnd0e commented 2 months ago

Please provide windows build in Releases.

P.S. Versions up to 0.15 I was able to compile myself, but now it depends on unstable feature:

   Compiling gitu v0.17.1
error[E0658]: use of unstable library feature 'result_option_inspect'
altsem commented 2 months ago

Would need some more information.

There are binary releases made on Github, and the CI is running tests on windows successfully (using stable rust 1.77.2).

Perhaps an upgrade in rust compiler would solve it, or running with this flag: cargo build --locked?

johnd0e commented 2 months ago

rustup update helped, thanks. But why then not provide windows build in Releases?

altsem commented 2 months ago

You're right, windows releases are actually not made. Should be easy to add 👍

altsem commented 2 months ago

This is now available, haven't tested it out properly. @johnd0e

johnd0e commented 2 months ago

It works, but.. it is too big: 45505024 Apr 20 16:59 gitu.exe The one compiled with cargo is more then 10 times smaller: 3719680 Apr 19 21:13 gitu.exe

altsem commented 2 months ago

How do you mean it is too big? It is bigger because the new release ships with a few syntax parser to support syntax highlighting. Unrelated to being a windows build. It'd be neat to make it smaller, but there an issue?

johnd0e commented 2 months ago

It is bigger because the new release ships with a few syntax parser to support syntax highlighting.

Alright then. I found it suspicious, not because it's just bigger, but because it's 12 times bigger. However, if this is expected, then there's no issue.

altsem commented 2 months ago

I added just a few of these parsers, there must be some way to reduce the binary size :thinking:. Ty for the heads up!