search

altsem / gitu

A TUI Git client inspired by Magit
MIT License
1.74k stars 89 forks source link

gitu doesn't build on Windows #39

Closed barba3 closed 6 months ago

barba3 commented 6 months ago

I tried installing gitu on Windows with cargo install --git https://github.com/altsem/gitu.git --locked, but it failed because the code uses signal_hook::iterator.

As per https://docs.rs/signal-hook/latest/signal_hook/iterator/index.html, signal_hook::iterator is not for Windows:

"Available non-Windows and crate feature iterator only."

altsem commented 6 months ago

Ah, added this for dev, purposes. But I don't think it's needed. If you remove it, does everything work?

altsem commented 6 months ago

@barba3 i made a new release where this should be fixed. If you can confirm it works, I'll close this! :)

barba3 commented 6 months ago

@altsem thank you for the quick fix! I tried installing it on Windows with cargo install gitu --locked and it installed correctly. Then I ran gitu and it worked well.