search

alttpo / sni

SNES Interface with gRPC API
MIT License
46 stars 12 forks source link

Use LUABRIDGE env vars in Connector.lua #20

Closed rmcauley closed 2 years ago

rmcauley commented 2 years ago

When playing games that use SNI, oftentimes the default port that SNI uses is occupied by a client listener port from another app and SNI will refuse to work until I reboot to clear the client port. I use the SNI_LUABRIDGE_LISTEN_PORT environment variable to get around this, but the Lua script doesn't use this environment variable by default.

This change allows me to set a specific port in my environment variables and have the Lua script work out of the box.

Tested in Windows, SNES9x rr with the SNI and Lua that ships with Archipelago 0.3.5.

JamesDunne commented 2 years ago

Nice, I like it. Does it work in BizHawk as well? This Lua script needs to at least run under snes9x-rr and bizhawk.

rmcauley commented 2 years ago

One of my community members says "just connected straight away" with Bizhawk. I can verify snes9x-rr. Both of us use the environment variable as we've both had numerous issues with the default port.

We can both only verify on Windows with the shipped Lua that comes with the Windows version of Archipelago, if that makes a difference.

JamesDunne commented 2 years ago

Sounds good to me. I'll test it out locally and then approve if all looks good.

JamesDunne commented 2 years ago

Tested on both BizHawk-2.8 and snes9x-rr-1.60 and looks good. Merged.