altugbakan / rs-tftpd

TFTP Server Daemon implemented in Rust
https://crates.io/crates/tftpd
MIT License
51 stars 14 forks source link

Add upload directory and download directory #14

Closed shuyuImpossible closed 10 months ago

shuyuImpossible commented 10 months ago

TFTP server can download from a directory while upload to another directory.

shuyuImpossible commented 10 months ago

@altugbakan please review, i am not familiar with rust, there may be some foolish coding error.

altugbakan commented 10 months ago

Hey! Thanks for the work, I changed Upload to Receive and Download to Send to fix potential confusions about who is uploading and who is downloading, now send is the directory that the server sends from, and receive is the directory to receive new files.

stappersg commented 10 months ago
On Sat, Nov 04, 2023 at 04:42:19AM -0700, Altu?? Bakan wrote:
> @altugbakan pushed 1 commit.
> 
> 1eb7363f98ebe85f313cc90d1bda7ab817bc157a  Rename upload and download to receive and send
> 

Sadly, very sadly, got that commit melted with the original commits.

It should have been in a separate commit.

Please prevent in future "constructions" like

    Co-authored-by: y1shu <yu.shu@nokia-sbell.com>
    Co-authored-by: Altu?? Bakan <mail@alt.ug>