New version rs-tftpd download become very slow

altugbakan / rs-tftpd

TFTP Server Daemon implemented in Rust

https://crates.io/crates/tftpd

MIT License

51 stars 14 forks source link

New version rs-tftpd download become very slow #9

Closed jinxsong123 closed 10 months ago

jinxsong123 commented 10 months ago

hi, Have you noticed that the download speed of the new version of tftp has become very slow? I tested it, download 10M file, speet 30s

The version is v0.2.8 Updating crates.io index Downloaded tftpd v0.2.8 Downloaded 1 crate (15.2 KB) in 3.34s Installing tftpd v0.2.8 Updating crates.io index Compiling tftpd v0.2.8 Finished release [optimized] target(s) in 8.76s Replacing /home/jinxsong/.cargo/bin/tftpd Replaced package tftpd v0.2.6 with tftpd v0.2.8 (executable tftpd)

jinxsong123 commented 10 months ago

I start the server using " tftpd -p 8888 -d /tmp/tftp --duplicate-packets 0" seems ok, so the default value of --duplicate-packets seems not 0

altugbakan commented 10 months ago

Ahh, thanks for catching that! Would you like to make a PR with the fix? If not, I can check that out later.

jinxsong123 commented 10 months ago

Sorry, I am not familiar with Rust

altugbakan commented 10 months ago

No worries! I was just asking it to welcome contributions.

altugbakan commented 10 months ago

Fixed with #11