Added support for PL/SQL.

joey2031 commented 4 years ago

Description

Fixes #1

Type of Change:

added support for PL/SQL. First I made a new file in extdata called PLSQL.tpl in this file I wrote a hello world
updated the read me to add PL/SQL in the "Markups and Supported Languages" feature
I noticed .sql was not on the same line as other languages that use -- to comment in extdata.Inlinecomments.txt so I fixed that
Code:
- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] This change requires a documentation update (software upgrade on readme file)
- [X] New feature (non-breaking change which adds functionality pre-approved by consensus)
User Interface N/A
Documentation Updated readMe

How Has This Been Tested?

I ran my PL/SQL code in a PL/SQL editor to confirm the hello world works

Checklist:

[X ] My PR follows the style guidelines of this project
[ X] I have performed a self-review of my own code or materials
[ X] I have commented my code or provided relevant documentation, particularly in hard-to-understand areas
[ X] I have made corresponding changes to the documentation
[ X] Any dependent changes have been merged

alucardthefish commented 4 years ago

Hey @joey2031 what is the extensions for PL/SQL? I think you missed to add that info to extdata/lang.dat

I don't know much about PL/SQL, but searching a little bit I think in order to make it functional it must be linked with extension files .pls instead of .sql since the hello world example provided by you would never be applied if it's associated with .sql extension. (thanks for moving .sql to its corresponded line)

exdata/lang.dat should be something like this:

.pls : plsql (recall that plsql must match to .tpl filename provided)

Lastly, please use lower case for the filename of extdata/plsql.tpl instead of extdata/PLSQL.tpl

alucardthefish commented 4 years ago

Also add .pls to the third line of extdata/InlineComments.txt

joey2031 commented 4 years ago

Hey @joey2031 what is the extensions for PL/SQL? I think you missed to add that info to extdata/lang.dat

I don't know much about PL/SQL, but searching a little bit I think in order to make it functional it must be linked with extension files .pls instead of .sql since the hello world example provided by you would never be applied if it's associated with .sql extension. (thanks for moving .sql to its corresponded line)

exdata/lang.dat should be something like this:

.pls : plsql (recall that plsql must match to .tpl filename provided)

Lastly, please use lower case for the filename of extdata/plsql.tpl instead of extdata/PLSQL.tpl

I just did some research, turns out it can be .sql or .pls but its better practice to use .pls since it indicates its a pl/sql script (didn't know that before). I can change it to .pls and fix the exdata/lang.dat file. Will also fix the file name. https://stackoverflow.com/questions/32688805/practical-difference-between-pls-and-sql-file-in-oracle

alucardthefish commented 4 years ago

I just did some research, turns out it can be .sql or .pls but its better practice to use .pls since it indicates its a pl/sql script (didn't know that before). I can change it to .pls and fix the exdata/lang.dat file. Will also fix the file name. https://stackoverflow.com/questions/32688805/practical-difference-between-pls-and-sql-file-in-oracle

Cool! thank you very much

joey2031 commented 4 years ago

I just did some research, turns out it can be .sql or .pls but its better practice to use .pls since it indicates its a pl/sql script (didn't know that before). I can change it to .pls and fix the exdata/lang.dat file. Will also fix the file name. https://stackoverflow.com/questions/32688805/practical-difference-between-pls-and-sql-file-in-oracle

Cool! thank you very much

Fixed everything, do I make a new PR? If you need me to fix anything else just let me know!

alucardthefish commented 4 years ago

Fixed everything, do I make a new PR? If you need me to fix anything else just let me know!

Almost done! just rename your file from extdata/PLSQL.tpl to extdata/plsql.tpl

Don't worry! keep commiting your changes to this same PR

joey2031 commented 4 years ago

Fixed everything, do I make a new PR? If you need me to fix anything else just let me know!

Almost done! just rename your file from extdata/PLSQL.tpl to extdata/plsql.tpl

Don't worry! keep commiting your changes to this same PR

Fixed it!

alucardthefish commented 4 years ago

@joey2031 I just merged your work! Thanks for your contribution

alucardthefish / CodeNowHere