alucas / Snorlax

Xposed module (Android) to check pokemons stats
Other
23 stars 7 forks source link

Not showing pikachu's hat #30

Closed alberturer closed 7 years ago

alberturer commented 7 years ago

First of all, i love your module, is very useful, congrats!. In the second place, I want to report a bug, I encountered 2 christmas pikachus but when i caught them, the hats disappear. I disabled the module and the hats show up. Can you check that please?

alucas commented 7 years ago

Hi, it's problably a proto bug, https://github.com/AeonLucid/POGOProtos is not uptodate. I will see what I can do.

suloku commented 7 years ago

I can confirm that disabling renaming brings back the hats. Same should apply to Raichu (yes, raichu keeps the hat).

ps: is there a way to implement ditto notification? From what I've read the client should know it's a ditto, since the colored circle depends on ditto's actual catch rate, and not the pokemon it is transformed into.

alucas commented 7 years ago

Please create a new ticket for the ditto question ;) I don't really know for now.

alucas commented 7 years ago

Can you try that file and tell my if that fix your problem ?

snorlax_proto_2.3.0_debug.apk.tar.gz

screenshot_20161213-021744

alberturer commented 7 years ago

I installed the debug version and i caught another santa pikachu but the issue persists. Btw, people on reddit say that the hats show up after evolving into raichu. Thanks for your effort.

alucas commented 7 years ago

I'm working with ElFinLazz and AeonLucid to update the proto files. I will produce a new debug apk in 1hour for you to test. Stay tuned!

alucas commented 7 years ago

snorlax_proto2.3.0_debug.apk.tar.gz

My USB cable just die, so I can't test anymore...

A312a2 commented 7 years ago

Yep that works

alberturer commented 7 years ago

Works like a charm. Thank you so much.

alucas commented 7 years ago

I just released 1.7.1. I will close that Issue if everything is good ;)

suloku commented 7 years ago

@alucas 1.7.1 won't work for me. As a side note, Xmas pikachu as wild encounter loaded just fine with 1.7.0 (same with 1.7.1). Maybe it's because my game is in a non-english language?

EDIT: I uninstalled and re-installed and now it works. I don't know why regular updating trough xposed module manager didn't work (I did reboot my phone after updating, and checked that snorlax was at 1.7.1 version). So it was my fault, sorry.