search

alucas / Snorlax

Xposed module (Android) to check pokemons stats
Other
23 stars 7 forks source link

Show encounter type in notification #36

Closed alexcheveau closed 7 years ago

alexcheveau commented 7 years ago

Take a look when you got the time. This is my first commit, so if I did something wrong just tell me :)

image

alucas commented 7 years ago

It's an interesting feature, but the notification title is now too large. So we need to fix that.

alucas commented 7 years ago

He modified too much code, that why I didn't merge that PR yet. But the part that display the origine seem good, it just need to be displayed differently.

alexcheveau commented 7 years ago

Haha sorry for that ;) What I did is just a cleaner way to pass params to mEncounterNotification.show Instead of passing 300 values, you pass only the Pokemon Class And for the title, agreed, using an emoji is a much better solution than showing "Wild" or "Incense"

alucas commented 7 years ago

I picked-up your code in the master branch, I will close that PR