Closed TylerVigario closed 9 months ago
I'll try to reproduce, haven't experienced that issue before, then again I don't have a lot of CD games but I believe I do have the RE and MGS games.
BTW, the head of the develop branch is now using tokio instead of async-std as its async runtime, the former is actually maintained and seems a lot more mature. I was hoping it would help with some of the hard to reproduce bugs I can't explain.
I previously used the develop
branch, but the web portion stopped functioning recently. I didn't want to start an issue for something that might be in progress or my own doing, so I reverted to main
.
EDIT 2: I confirmed this is present in the latest develop
.
EDIT:
No matter how often I (begrudgingly) agree to sort a different .m3u
, it keeps wanting to do it. If I get some time, I'll look over the logic for sorting and see if I spot any apparent issues.
[root@tylervigario Temp]# oxyromon purge-roms -t -m -o
Processing missing ROM files
Processing trashed ROM files
Processing orphan ROM files
[root@tylervigario Temp]# oxyromon sort-roms -a
Processing "Atari - 2600"
Nothing to do
Processing "Atari - 5200"
Nothing to do
Processing "Atari - 7800"
Nothing to do
Processing "Atari - Jaguar (J64)"
Nothing to do
Processing "Atari - Lynx"
Nothing to do
Processing "MAME"
Nothing to do
Processing "Microsoft - Xbox"
Nothing to do
Processing "Microsoft - Xbox 360"
Nothing to do
Processing "Nintendo - Game Boy"
Nothing to do
Processing "Nintendo - Game Boy Advance"
Nothing to do
Processing "Nintendo - Game Boy Color"
Nothing to do
Processing "Nintendo - GameCube"
Nothing to do
Processing "Nintendo - Nintendo 3DS (Encrypted)"
Nothing to do
Processing "Nintendo - Nintendo 64 (BigEndian)"
Nothing to do
Processing "Nintendo - Nintendo DS (Decrypted)"
Nothing to do
Processing "Nintendo - Nintendo Entertainment System (Headered)"
Nothing to do
Processing "Nintendo - Super Nintendo Entertainment System"
Nothing to do
Processing "Nintendo - Virtual Boy"
Nothing to do
Processing "Nintendo - Wii"
Nothing to do
Processing "Sega - 32X"
Nothing to do
Processing "Sega - Game Gear"
Nothing to do
Processing "Sega - Master System - Mark III"
Nothing to do
Processing "Sega - Mega Drive - Genesis"
Nothing to do
Processing "Sony - PlayStation"
Summary:
"Rival Schools - United by Fate (USA).m3u" -> "/mnt/storage/Nextcloud/__groupfolders/1/Roms/Sony - PlayStation/Rival Schools - United by Fate (USA).m3u"
⠐
Processing "Sony - PlayStation 2"
Nothing to do
Processing "Sony - PlayStation 3"
Nothing to do
Processing "Sony - PlayStation Portable"
Nothing to do
[root@tylervigario Temp]# oxyromon sort-roms -a
Processing "Atari - 2600"
Nothing to do
Processing "Atari - 5200"
Nothing to do
Processing "Atari - 7800"
Nothing to do
Processing "Atari - Jaguar (J64)"
Nothing to do
Processing "Atari - Lynx"
Nothing to do
Processing "MAME"
Nothing to do
Processing "Microsoft - Xbox"
Nothing to do
Processing "Microsoft - Xbox 360"
Nothing to do
Processing "Nintendo - Game Boy"
Nothing to do
Processing "Nintendo - Game Boy Advance"
Nothing to do
Processing "Nintendo - Game Boy Color"
Nothing to do
Processing "Nintendo - GameCube"
Nothing to do
Processing "Nintendo - Nintendo 3DS (Encrypted)"
Nothing to do
Processing "Nintendo - Nintendo 64 (BigEndian)"
Nothing to do
Processing "Nintendo - Nintendo DS (Decrypted)"
Nothing to do
Processing "Nintendo - Nintendo Entertainment System (Headered)"
Nothing to do
Processing "Nintendo - Super Nintendo Entertainment System"
Nothing to do
Processing "Nintendo - Virtual Boy"
Nothing to do
Processing "Nintendo - Wii"
Nothing to do
Processing "Sega - 32X"
Nothing to do
Processing "Sega - Game Gear"
Nothing to do
Processing "Sega - Master System - Mark III"
Nothing to do
Processing "Sega - Mega Drive - Genesis"
Nothing to do
Processing "Sony - PlayStation"
Summary:
"Rival Schools - United by Fate (USA).m3u" -> "/mnt/storage/Nextcloud/__groupfolders/1/Roms/Sony - PlayStation/Rival Schools - United by Fate (USA).m3u"
⠒
Proceed? [Y/n]
``
I'm having trouble trying to reproduce, I even have a unit test covering that particular use case (import multi-disc game, generate playlist, then call sort-roms to move to 1G1R).
Could you quickly check where the file currently is, its permissions as well as its parent folder, and possibly try purge-roms -m -o -t
?
This is happening to CUE
files! I dumped all the Redump CUE
files into the import directory (obviously running import-roms
) and then ran generate-playlists
, which creates m3u
files for DAT entries that only have the CUE
file. Maybe check for ROM completeness before generating playlist files?
Ah! I don't have orphan CUE files, that explains it. Yes, I'll change it so it only generates playlists when you have all the required roms.
https://github.com/alucryd/oxyromon/commit/c71b720fbed54aca4f883f76d3d6af7aa8c1eae6 should do the trick. I went a step further and made sure all the games in a set are complete before generating the playlist. For example if you've got the full BIN+CUE FF7 disc 1 and 2 but are missing the 3rd one, the playlist isn't generated.
And thanks a lot for the gift, that's very kind of you. I wish you a happy new year :)
@alucryd I appreciate your help updating this; it appears to be working great! I wish you a great new year as well!
For some reason,
generate-playlists
andsort-roms
are not playing nice. I'm glad that it doesn't affect GameCube as well.I've reduced the output and split the commands to make it easier to read