search

alucryd / oxyromon

Rusty ROM OrgaNizer
Other
114 stars 14 forks source link

Build and run the utility from docker #30

Closed mjc closed 2 years ago

mjc commented 2 years ago

This is a multistage dockerfile to build and run both the webui and the app in docker.

Some additions that would improve the experience of using the app inside docker:

mjc commented 2 years ago

Whoops, this needs current develop to be merged first

alucryd commented 2 years ago

Hi there, thanks for the dockerfile! Somehow didn't notice you made a PR, and just made your life harder by pushing a bunch of new commits :/

Could you rebase on develop and modify the PR to be merged in develop instead of master ?

Currently working on arcade systems and I should be able to merge and release by the end of the week.

alucryd commented 2 years ago

This is a multistage dockerfile to build and run both the webui and the app in docker.

Some additions that would improve the experience of using the app inside docker:

  • [ ] detecting interactive or noninteractive, for download-dats
  • [ ] allowing a list to be provided to download-dats
  • [ ] env vars for ADDRESS and PORT

I'll see what I can do about these, should be no problem at all.

  • [ ] not crashing on invalid naming conventions

What would you like instead? If the name can't be parsed, a lot of information is lost and you essentially give up on region and release/flag based filtering. I just did that for arcade systems where naming is basically atrocious and I hope it can be improved in the future.

  • [ ] responding to signals more appropriately

Could you be more specific? Is there an issue with sigterm? I'm using a special handler in the server to cleanly close the sqlite database, it may introduce a little delay but is necessary for the db to not get corrupt.