alucryd / oxyromon

Rusty ROM OrgaNizer
Other
110 stars 13 forks source link

[Issue] Conversion failed because of Rom Name? #96

Open Zombanana opened 10 months ago

Zombanana commented 10 months ago

I think I found an issue with roms, which begin with a "-" in name.

This error ocur on this rom: http://redump.org/disc/107483/

I don't know if it's oxyromon or even on of the converters problem, but it seems it tries to interpret the name as a switch? "-8"

Screenshot 2023-09-04 172423

I am on WIndows 11, 64bit. Trying to convert this "Redump - Sony PlayStation Portable" rom from .iso to .cso.

I will try to fix the error myself by manually editing the rom name inside the dat file and manually import it into oxyromon. I will later report / confirm if the conversion work, after renaming the filename.

alucryd commented 10 months ago

Hmm, it appears to be the case indeed. I've got an external library doing the parsing, will try to see if they have a workaround, if not I'll submit a bug report over there.

Zombanana commented 10 months ago

Hi alucryd,

thanks for your work again. I have also done indeed the test. I just have renamed the file and the name of the rom inside the dat.

Renaming it from "-8 (Japan).iso" to "8 (Japan).iso". That work fine. So the - inside the begining of the name seems to produce an error.

bhartshorn commented 9 months ago

Many command line applications use '--' to indicate that all following inputs are not flags, the parsing library might support that. Was it tested?

alucryd commented 9 months ago

I actually looked at this the wrong way, this is does not concern the parsing library I use at all. This is an issue with the tool used to extract the ISO. @Zombanana What format was the file originally? Was that an ISO inside an archive?

Zombanana commented 6 months ago

I am not sure about it, as it is a while since I converted my set.

I have managed my Sets with RomVault before. I assume it was plain iso or torrentzipped, but I don't know for sure anymore.

monyarm commented 1 week ago

I have the same issue with:

❯ oxyromon convert-roms -f CHD -d -s "Sony - PlayStation"
Processing "Sony - PlayStation"
Creating "Incredible Hulk, The - The Pantheon Saga (USA).chd"
Error: SimpleError { err: "Error parsing input file (/mnt/Games/Sony - PlayStation/Incredible Hulk, The - The Pantheon Saga (USA).cue: No such file or directory)\n\nFatal error occurred: 1\n" }

Though the weird thing is I already have it converted to chd, so I'm not sure why it would be trying to convert it again. (I was running it to have it convert my newly ripped and imported games.)

alucryd commented 1 week ago

@monyarm It looks like another issue, could you open a dedicated one, and specify if it's on the stable release or the develop branch? I should be able to reproduce easily.