alugowski / fast_matrix_market

Fast and full-featured Matrix Market I/O library for C++, Python, and R
BSD 2-Clause "Simplified" License
75 stars 7 forks source link

Ensure skew-symmetric matrices are not loaded into an unsigned type #19

Closed alugowski closed 1 year ago

alugowski commented 1 year ago

skew-symmetric negates values which causes incorrect values on unsigned types.

codecov-commenter commented 1 year ago

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.07 :tada:

Comparison is base (28ae643) 96.60% compared to head (50610db) 96.68%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #19 +/- ## ========================================== + Coverage 96.60% 96.68% +0.07% ========================================== Files 19 19 Lines 1415 1416 +1 Branches 159 159 ========================================== + Hits 1367 1369 +2 + Misses 48 47 -1 ``` | [Impacted Files](https://codecov.io/gh/alugowski/fast_matrix_market/pull/19?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Adam+Lugowski) | Coverage Δ | | |---|---|---| | [include/fast\_matrix\_market/read\_body.hpp](https://codecov.io/gh/alugowski/fast_matrix_market/pull/19?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Adam+Lugowski#diff-aW5jbHVkZS9mYXN0X21hdHJpeF9tYXJrZXQvcmVhZF9ib2R5LmhwcA==) | `97.81% <100.00%> (+0.02%)` | :arrow_up: | ... and [1 file with indirect coverage changes](https://codecov.io/gh/alugowski/fast_matrix_market/pull/19/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Adam+Lugowski) Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Adam+Lugowski). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Adam+Lugowski)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.