search

alugowski / fast_matrix_market

Fast and full-featured Matrix Market I/O library for C++, Python, and R
BSD 2-Clause "Simplified" License
75 stars 7 forks source link

Adding GraphBLAS to Ubuntu CI Runs #20

Closed jamesETsmith closed 1 year ago

jamesETsmith commented 1 year ago

General

Hi @alugowski, thanks for putting this package together! I noticed your comments on your workflow about installing GraphBLAS on Ubuntu and wanted to suggest an alternative method for installation that's used by several of the GraphBLAS authors in the LAGraph project.

Details

Most of my changes are adapted from the CI workflow used by LAGraph. The GraphBLAS authors update the conda-forge regularly with binary releases you can pull into CI with just a wget command. You could use this same strategy for other operating systems too and I'm happy to add those to this PR if you're interested.

Next Steps

Happy to discuss any comments/questions/suggestions, just let me know!

alugowski commented 1 year ago

Great! Thank you!

Do you have a method for Windows? brew works well for macOS so I don't think we need tricks there.

jamesETsmith commented 1 year ago

Happy to help! I think we can use the same strategy for Windows because GraphBLAS publishes releases for those on conda-forge too. I can open a new PR for that soon

alugowski commented 1 year ago

Sounds good!