alugowski / fast_matrix_market

Fast and full-featured Matrix Market I/O library for C++, Python, and R
BSD 2-Clause "Simplified" License
75 stars 7 forks source link

GraphBLAS binding: sum duplicates #34

Closed alugowski closed 1 year ago

alugowski commented 1 year ago

The previous nullptr argument for GrB_Matrix_build's dup argument would cause a GrB_INVALID_VALUE (-3) to be thrown if there are any duplicate values in the matrix market file. Use GrB_PLUS instead.

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.01 :warning:

Comparison is base (f030668) 94.18% compared to head (51e427c) 94.18%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #34 +/- ## ========================================== - Coverage 94.18% 94.18% -0.01% ========================================== Files 22 22 Lines 2132 2131 -1 Branches 269 269 ========================================== - Hits 2008 2007 -1 Misses 124 124 ``` | [Impacted Files](https://app.codecov.io/gh/alugowski/fast_matrix_market/pull/34?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Adam+Lugowski) | Coverage Δ | | |---|---|---| | [include/fast\_matrix\_market/app/GraphBLAS.hpp](https://app.codecov.io/gh/alugowski/fast_matrix_market/pull/34?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Adam+Lugowski#diff-aW5jbHVkZS9mYXN0X21hdHJpeF9tYXJrZXQvYXBwL0dyYXBoQkxBUy5ocHA=) | `87.76% <100.00%> (-0.03%)` | :arrow_down: |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.