search

alugowski / fast_matrix_market

Fast and full-featured Matrix Market I/O library for C++, Python, and R
BSD 2-Clause "Simplified" License
75 stars 7 forks source link

Refactor read_chunk to eliminate possible compiler warning #65

Open alugowski opened 9 months ago

alugowski commented 9 months ago

Previous code could cause a compiler warning with overly-pedantic settings: 'value' may be used uninitialized

Previous behavior was correct, only initialized values would be read. New version also has simpler logic.

codecov[bot] commented 9 months ago

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (b8e3403) 95.84% compared to head (96d99ea) 95.77%.

Files Patch % Lines
include/fast_matrix_market/read_body.hpp 92.68% 3 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #65 +/- ## ========================================== - Coverage 95.84% 95.77% -0.07% ========================================== Files 22 22 Lines 1563 1561 -2 Branches 176 173 -3 ========================================== - Hits 1498 1495 -3 - Misses 65 66 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.