aluhrs13 / TheMiniIndex

Crowd-sourced library of 3d models (minis, terrain, scatter, etc.) for D&D, Pathfinder, and other tabletop games.
https://www.TheMiniIndex.com/
25 stars 5 forks source link

New search page integration stuff #152

Closed aluhrs13 closed 4 years ago

aluhrs13 commented 4 years ago

@anaximander23 Tracking minor things we (I can tackle all of these probably unless something jumps out to you) should look at as I look at integrating this.

anaximander23 commented 4 years ago

The missing icon font is probably just because I missed it when setting up webpack; I notice that site.js has an entry for the open-iconic CSS, but no fonts, so I presume it's just a matter of adding the requisite imports there.

The thing about not removing tags properly will just be an oversight in tags-tagify.js somewhere. It might be that instead of what's happening in onFormSubmitted(), it would be better to attach to the add and remove events and keep tagsValue in sync that way. I felt like that was mildly hacky anyway.

aluhrs13 commented 4 years ago

image

Styling pretty much there :)