TLS fix - Githubissues

aluisiora / node-routeros

Mikrotik Routerboard RouterOS API for NodeJS

MIT License

100 stars 45 forks source link

Closed danlobo closed 6 years ago

danlobo commented 6 years ago

Changes on the TLS constructor and connection methods of Connector.ts
Added one test to check. To connect to a mikrotik that doesn't have a certificate, use the ciphers: 'ADH-AES256-GCM-SHA384:DHE-RSA-AES256-GCM-SHA384'tls option.

aluisiora commented 6 years ago

This is gonna take a while, I need it written in a way Typescript can compile so it might need some adaptation.

aluisiora commented 6 years ago

Nicely done!

Quick note though, try not to commit distributable code (a.k.a. dist/ folder) with the source code, check the .gitignore if it's there.

Regardless, good work! Merged!