search

alumae / gst-kaldi-nnet2-online

GStreamer plugin around Kaldi's online neural network decoder
Apache License 2.0
185 stars 100 forks source link

initial support for nnet3 #41

Closed yifan closed 8 years ago

yifan commented 8 years ago

support nnet3 decoding. It basically just change all the nnet2 decoding call to nnet3. threaded decoder is not supported though.

alumae commented 8 years ago

Wow, thanks a lot. Ideally there would be only one GStreamer plugin, and it would recognize automatically (or via a property) whether nnet2 or nnet3 code should be used. What do you think, would this be difficult to implement? Otherwise we would have a lot of code duplication.

yifan commented 8 years ago

It is surely doable. The only thing is that some objects in KALDI are not inherited from same super class. Take AmNnetSimple for example, we either keep two pointers in class, and use one of them depending on nnet2 or nnet3 configuration, or we use a 'void *'. Either way, it is not the cleanest way. Let me try it and let's see how it looks like.

yifan commented 8 years ago

closed because new pull request is available