search

alump / GridStack

Vaadin layout add-on using gridstack.js library
Apache License 2.0
10 stars 7 forks source link

Fix for Issue "Optional loading of JQuery and JQuery-ui #13" #14

Open rlsutton1 opened 8 years ago

rlsutton1 commented 8 years ago

This fix maintains backwards compatibility of the API.

GridStackLayout works exactly as before.

Users needing to suppress the loading of JQuery and JQuery-UI should use GridStackLayoutNoJQuery rather than GridStackLayout.

changes: I have renamed GridStackLayout to GridStackLayoutNoJQuery and removed the references to jquery and jquery-ui in the @JavaScript annotation

I have created a replacement GridStackLayout which extends GridStackLayoutNoJQuery and has an @JavaScript annotation which loads the jquery and jquery-ui as before.

All other changes are very minimal, referencing GridStackLayoutNoJQuery where necessary.

alump commented 8 years ago

I have to review this later, there are few things I might do differently.

alump commented 8 years ago

Have to fist check if I could pair this to code somehow: https://api.jquery.com/jquery.noconflict/