Feature / Exchanges - handle exchanges common errors

[Torres-ssf]

Summary

• [x] Implement helper function to handle exchanges common errors ( invalid Api key and exchange down)
• [x] Make all exchanges request errors user helper function:
  • [x] Bitfinex
  • [x] Binance
  • [x] Bittrex
  • [x] Bitmex
  • [x] Poloniex
  • [x] Gate
  • [x] Valr
• [x] Review occorrences of AlunaError without metadata prop
• [x] Close #56

[arboleya]

@Torres-ssf It looks like you based this branch on the wrong branch:

• https://github.com/alunacrypto/aluna.js/pull/47

Although I've already merged that to master, some dirty commits are still showing up here.

Not sure what is going on, but it needs a review.

[Torres-ssf]

@Torres-ssf It looks like you based this branch on the wrong branch:

• Feature / Request counter #47

Although I've already merged that to master, some dirty commits are still showing up here.

Not sure what is going on, but it needs a review.

@arboleya I started from the branch feature/request-counter to avoid any possible conflict later when the branch would have merged to master. In this current branch, I need to refact all exchanges Http classes to apply a new approach to handle exchange common errors, which later on would result in many conflicts with the request counter approach.

I tried to reproduce what happened here in a dummy repository and it seems to me that this is the normal behavior, the commits from the originated branch do not disappear

• Branch 1

• Branch 2 ( created/originated from branch 1 )

The commits from branch 1 didn't disappear from branch 2 PR even after I have merged branch 1 to master ( while branch-2 PR was yet not merged )

After merging everything, the commits are shown this way

@arboleya Please let me know if I misunderstood the issue that you are pointing out