search

alunny / node-xcode

tools and utilities for working with xcode/ios projects
Apache License 2.0
226 stars 105 forks source link

Embed custom frameworks #46

Closed soflare closed 2 years ago

imhotep commented 9 years ago

Hello @soflare

Thanks for your pull request. Please provide associated test before I can merge this in.

Thanks!

soflare commented 9 years ago

@imhotep There is a problem that the "Embed Frameworks" group may not exist. This causes addFramework fail. The problem is similar with #43 which is caused by missing "Frameworks" group. The problem is hard to fix because there is no functions for creating/removing PBXGroup.

grabbou commented 8 years ago

See that method for creating PBXGroup: https://github.com/rnpm/rnpm-plugin-link/blob/master/src/ios/createGroup.js and usage: https://github.com/rnpm/rnpm-plugin-link/blob/master/src/ios/copyAssets.js#L28-L35