Remove custom frameworks correctly

alunny / node-xcode

tools and utilities for working with xcode/ios projects

Apache License 2.0

225 stars 105 forks source link

Remove custom frameworks correctly #86

Closed vladimir-kotikov closed 8 years ago

vladimir-kotikov commented 8 years ago

This PR fixes the bug in custom frameworks removal logic due to incorrect argument passed to removeFromFrameworkSearchPaths function, which expects pbxFile as argument but gets file path.

The bug hadn't been visible because of too weak validation of arguments for path methods in Node pre-6.0 and causes TypeError only when running on Node@>=6.0 (corresponding change is nodejs/node#/5348R737)

Here is corresponding ticket in Cordova JIRA, caused by this bug - CB-11200

nikhilkh commented 8 years ago

@imhotep Could you please help review & merge this. We'll also need a release - this breaks Cordova's node 6.0 compatibility.

vladimir-kotikov commented 8 years ago

Thanks, @imhotep !