search

alunny / node-xcode

tools and utilities for working with xcode/ios projects
Apache License 2.0
225 stars 105 forks source link

addStaticLibrary problem #91

Open aylarov opened 8 years ago

aylarov commented 8 years ago

Hi, I've been trying to use the addStaticLibrary func and had some issues with it:

  1. I'm not sure about if (this.hasFile(file.path)) return false; code, since if the lib exists the function just returns false , if I change it to if (!this.hasFile(file.path)) return false; then
  2. In addToLibrarySearchPaths function there is the following code: if (unquote(buildSettings['PRODUCT_NAME']) != this.productName) continue;

in case of React Native iOS project (I've added fhe file) , this.productName is always $(TARGET_NAME) and continue doesn't happen only for the test target, while happens for the main target, so library isn't added to the main target Library Search Path.

project.txt

grigoryvp commented 8 years ago

Bounty added for this issue: https://www.bountysource.com/issues/34187955-addstaticlibrary-problem

grigoryvp commented 8 years ago

Bounty increased to $100

aylarov commented 8 years ago

Ok, I figured out the problem productName getter returns the first found PRODUCT_NAME from configurations, which is $(TARGET_NAME) in case of React Native project and refers to Test target. I will modify addToLibrarySearchPaths function to add path to lib search paths for all targets and make pull request.

aylarov commented 8 years ago

@imhotep , please let me know what's required to have this in the next release.