search

aluxnimm / outlookcaldavsynchronizer

Sync Outlook with Google, SOGo, Nextcloud or any other CalDAV/CardDAV server
GNU Affero General Public License v3.0
932 stars 100 forks source link

Some phone numbers not deleted correctly in Outlook #342

Closed feinidev closed 2 years ago

feinidev commented 2 years ago

Hello,

we are syncing contacts from a CardDAV-Server (SOGo) to Outlook via "Outlook <- Server (Replicate)" and noticed that some phone numbers are not deleted in Outlook although they were deleted on the CardDAV server.

Steps to reproduce:

  1. Contact on CardDAV server has a phone number of type "Pager" or (none)
  2. After sync the contact's number appears as expected in Outlook
  3. Delete the number on CardDAV server
  4. Sync again
  5. The number still exists on the contact in Outlook we expected the number to be deleted in Outlook aswell.

We figured out that in ContactEntityMapper > MapTelephoneNumber2To1() the "main" numbers are set to string.Empty, but others like PagerNumber and OtherTelephoneNumber are not.

2022-02-14_MapTelephoneNumber2To1

When adding these lines our described scenario works as expected. Are these phone types intentionally left out for other cases of synchronization or are they really missing?

CalDav Synchronizer 4.1.0.0 (same in 4.0.0.0)

aluxnimm commented 2 years ago

Thx for the report, you are right, those are missing. Will be added in the next release.