Fix tests and add dot env

alvarcarto / url-to-pdf-api

Web page PDF/PNG rendering done right. Self-hosted service for rendering receipts, invoices, or any content.

MIT License

7.03k stars 779 forks source link

Fix tests and add dot env #105

Closed alanfriedman closed 5 years ago

alanfriedman commented 5 years ago

Fixes broken tests by increasing mocha timeout, replacing PDF parser with pdf-parse and fixing some PDF text character encoding issues
Adds dotenv for easily loading environment variables during local development

alanfriedman commented 5 years ago

Partial dupe of #103. If we merge that one I can delete everything except for dotenv from this PR.

kimmobrunfeldt commented 5 years ago

Thanks for the effort! The other fixes are very welcome, but don't want to add dotenv changes at this point. The other changes were addressed mostly in #103 except for the timeout increases and the character replacements. Those would be helpful and I would happily merge them to the project.

dotenv: it's definitely a great tool, but I'd prefer not to change the env mechanism now. At some point I might add the dotenv with a few other features like env type checking, which I've used in other projects.

kimmobrunfeldt commented 5 years ago

@alanfriedman I copy-pasted the character replacement part from this PR to master and fixed it while doing other changes. I would've rather took your commit for it to give the correct credit but my time is quite short so I need to do all fixes now, otherwise I'll come back to this PR in a few months and it will delay.

Thanks for the PR in any case, it was helpful!