search

alvarcarto / url-to-pdf-api

Web page PDF/PNG rendering done right. Self-hosted service for rendering receipts, invoices, or any content.
MIT License
7.03k stars 779 forks source link

Docker wrapper referenced in README is based on a fork #110

Open typpo opened 5 years ago

typpo commented 5 years ago

First, thank you all for your work on this excellent project.

The README references a docker wrapper that builds off a forked version of this repository at https://github.com/onesdk/url-to-pdf-api.

This is a bit misleading as it is 52 commits behind master, which means new fixes and features such as image rendering are not available. In the worst case, promoting a Docker image based on a fork could be a security risk.

Are you open to a PR to add a Dockerfile to this repository, or link to another Docker image that is based directly on this repository?

kimmobrunfeldt commented 5 years ago

Good catch. I'd be willing to add a Dockerfile here.

BobCashStory commented 4 years ago

did a pr for this : https://github.com/alvarcarto/url-to-pdf-api/pull/142

AubreyHewes commented 4 years ago

@BobCashStory @kimmobrunfeldt

This issue seems to be superseded/resolved by actual changes to the README.md.

The current referenced docker image is not using a fork, the referenced docker image is actually very usable and clones the master of this repo on build. How actual the image is, is up to interpretation.

I am not saying this project should not have it's own docker image, but that this issue is moot :cow2: .