search

alvarcarto / url-to-pdf-api

Web page PDF/PNG rendering done right. Self-hosted service for rendering receipts, invoices, or any content.
MIT License
7.03k stars 779 forks source link

Remove old goto options, update documentation and default. #135

Closed louim closed 4 years ago

louim commented 4 years ago

Hello!

While using this library, we've seen that the readme and the code still mentioned options networkIdleInflight and networkIdleTimeout. Those options are long gone from Puppeteer. I updated the readme and removed references to those options in the code.

I also changed the default from networkidle2 to networkidle0. Based on the doc, this seems the most logical options users would want when rendering. I've made a separate commit for that so it can be removed if you would rather not change the current default.

kimmobrunfeldt commented 4 years ago

Thanks!