search

alvarcarto / url-to-pdf-api

Web page PDF/PNG rendering done right. Self-hosted service for rendering receipts, invoices, or any content.
MIT License
7.01k stars 774 forks source link

Export metrics for scraping. #17

Closed bweston92 closed 6 years ago

bweston92 commented 6 years ago

Allows for monitoring.

kimmobrunfeldt commented 6 years ago

Thanks for the PR! Just a few questions.

What is the need for this? Are there some other external dependencies to run this than express-prom-bundle package?

bweston92 commented 6 years ago

Hi @kimmobrunfeldt basically I can determine when error rates get high, when requests start to take longer and I can auto scale it.

kimmobrunfeldt commented 6 years ago

Ok. Thanks for the effort, but I would like to keep the scope of the service quite small. Monitoring solutions vary across projects so I think it would be better to keep it out of this service's scope.

I'd say the best workflow for using this metrics would be to maintain the monitoring solution in a fork of this repo. I'll re-evaluate this if there's a general interest to monitoring.