search

alvarcarto / url-to-pdf-api

Web page PDF/PNG rendering done right. Self-hosted service for rendering receipts, invoices, or any content.
MIT License
7.03k stars 779 forks source link

Add .travis.yml with ESLint tests. #18

Closed bweston92 closed 7 years ago

bweston92 commented 7 years ago

These are however failing as the eslint is not followed so there will need to be code changes to get them passing.

bweston92 commented 7 years ago

@adaptive if you've approved do you want to merge?

bweston92 commented 7 years ago

@kimmobrunfeldt changes should have been made now.

kimmobrunfeldt commented 7 years ago

I really appreciate the changes. However the same functionality was added in this other PR: https://github.com/alvarcarto/url-to-pdf-api/pull/28.

So the test, linter and travis setup are now in master. browser features are needed in pdf core where we use window in inside page.evaluate. Thank you in any case!