search

alvarcarto / url-to-pdf-api

Web page PDF/PNG rendering done right. Self-hosted service for rendering receipts, invoices, or any content.
MIT License
7.03k stars 779 forks source link

Updating puppeteer to support newer Chrome features #188

Open emersonthis opened 2 years ago

emersonthis commented 2 years ago

Recently I tried to render a page that uses the newish CSS aspect-ratio and the resulting screenshot doesn't recognize it. I suspect the reason is that this project is pinned to puppeteer v2 which predates Chrome support for aspect-ratio.

Puppeteer is currently on v19 and it looks like Chrome added support for aspect-ratio around the time Puppeteer v13 was released. I tried updating package.json to newer versions but the API in those newer versions has changed (in ways I have not studied closely yet) so the app errors out.

samuliasmala commented 1 year ago

@kimmobrunfeldt if I create a PR to update the Puppeteer would you consider merging it?

emersonthis commented 1 year ago

@samuliasmala If for some reason the maintainers don't want to support newer Puppeteer my company would be open to maintaining a fork.

PrimeDominus commented 1 year ago

@samuliasmala If for some reason the maintainers don't want to support newer Puppeteer my company would be open to maintaining a fork.

If you do create a maintained fork please let us know 😄

emersonthis commented 1 year ago

@samuliasmala @PrimeDominus We just forked the repo: https://github.com/userevidence/url-to-pdf-api

if I create a PR to update the Puppeteer would you consider merging it?

We don't have the bandwidth to tackle this ourselves at the moment, but if anyone has time we'd certainly merge a PR.