Upgrade Puppeteer to 1.1.0

alvarcarto / url-to-pdf-api

Web page PDF/PNG rendering done right. Self-hosted service for rendering receipts, invoices, or any content.

MIT License

7.03k stars 779 forks source link

Upgrade Puppeteer to 1.1.0 #42

Closed kimmobrunfeldt closed 6 years ago

kimmobrunfeldt commented 7 years ago

[x] Upgrade Puppeteer version
[x] Start using setContent instead of the old hack
[x] Increase body size limit because setContent can handle it
[x] Test with larger

kimmobrunfeldt commented 6 years ago

Unfortunately this issue is still open: https://github.com/GoogleChrome/puppeteer/issues/728 so the fix I was hoping for didn't land in new Puppeteer releases. The issue remains that we can't render large sized HTML in body.

Ohems commented 6 years ago

This might be a good chance to enable Puppeteer options footerTemplate and headerTemplate like in PR #56. That would also fix issue 22

kimmobrunfeldt commented 6 years ago

Addressed in https://github.com/alvarcarto/url-to-pdf-api/pull/76.