search

alvarcarto / url-to-pdf-api

Web page PDF/PNG rendering done right. Self-hosted service for rendering receipts, invoices, or any content.
MIT License
7.03k stars 779 forks source link

Another approach for docker #48

Closed jonafrank closed 5 years ago

jonafrank commented 6 years ago

Hi, here is another approach using docker to run the API with docker-compose and gulp in order to refresh the server in development mode.

kimmobrunfeldt commented 5 years ago

Thanks for the effort! Docker is convenient, but don't want to add the docker complexity into this repo now. It increases the maintenance effort because of e.g. duplicate environment variable definitions. If those could be ironed out so that docker setup wouldn't need duplicate definitions, it would be good to merge. Closing this now, but willing to merge if the issues I mentioned can be solved.