search

alvarcarto / url-to-pdf-api

Web page PDF/PNG rendering done right. Self-hosted service for rendering receipts, invoices, or any content.
MIT License
7.01k stars 774 forks source link

Cookies support #62

Closed neslinesli93 closed 5 years ago

neslinesli93 commented 6 years ago

I was having difficulties getting the cookies to be sent with my request, and I think I may have found the problem. This function here is missing cookies assignment, and therefore the resulting cookies array is always empty.

Am I missing something? Thanks for the library by the way - it's just awesome!

lsaini commented 6 years ago

I agree. Same case was with me as well and cookies were not set.

kimmobrunfeldt commented 6 years ago

Seems like a bug yes. I've missed this part in the PR review. Bug fix PR welcome.