Add support to 0 timeout requests

alvarcarto / url-to-pdf-api

Web page PDF/PNG rendering done right. Self-hosted service for rendering receipts, invoices, or any content.

MIT License

7.01k stars 774 forks source link

Add support to 0 timeout requests #63

Closed neslinesli93 closed 5 years ago

neslinesli93 commented 6 years ago

As written inside README.md, you can pass the value 0 to goto.timeout when performing a request to /api/render. However, this is supported from puppeteer 0.12.0, while this project currently uses 0.11.0. I've seen that there is a branch for updating to the newest puppeteer, so this is maybe a non-issue (but the README could be updated before we actually merge the new branch)

kimmobrunfeldt commented 6 years ago

Puppeteer has now been upgraded to 1.6.0 in master. Also published in the demo app running in Heroku. Maybe this is fixed now also?

kimmobrunfeldt commented 5 years ago

Closing due to inactivity.