search

alvarcarto / url-to-pdf-api

Web page PDF/PNG rendering done right. Self-hosted service for rendering receipts, invoices, or any content.
MIT License
7.03k stars 779 forks source link

update puppeteer version 1.6.0 #74

Closed artistictechie closed 6 years ago

kimmobrunfeldt commented 6 years ago

Could you remove the pdf.footerTemplate stuff from this PR because it's doing more than just upgrading the puppeteer version. The footer template isn't now working via query parameters, needs a change here also: https://github.com/alvarcarto/url-to-pdf-api/blob/master/src/http/pdf-http.js#L46

kimmobrunfeldt commented 6 years ago

Thanks for the contribution. I continued this PR and fixed the footer and header templates in this PR: https://github.com/alvarcarto/url-to-pdf-api/pull/76.

To make future contributions easier, please only add one change at a time. In this case it would be easier to merge the version bump and support for footer/header templates separately.