Thanks for the effort! Docker is convenient, but don't want to add the docker complexity into this repo now. It changes they way environment variables are passed to the app in a way which I wouldn't want to merge. They should be defined in an .env file in case there will be secrets. This repo doesn't have any but I want to keep this service as an example setup for new projects, so that it would work even if there were secrets in the env variables. With the cross-env style, you'd need to commit the secrets into package.json if I read correctly.
I think passing environment variables to docker is not a great developer experience and somehow that should be solved before merge.
Thanks for the effort! Docker is convenient, but don't want to add the docker complexity into this repo now. It changes they way environment variables are passed to the app in a way which I wouldn't want to merge. They should be defined in an .env file in case there will be secrets. This repo doesn't have any but I want to keep this service as an example setup for new projects, so that it would work even if there were secrets in the env variables. With the cross-env style, you'd need to commit the secrets into package.json if I read correctly.
I think passing environment variables to docker is not a great developer experience and somehow that should be solved before merge.