search

alvarcarto / url-to-pdf-api

Web page PDF/PNG rendering done right. Self-hosted service for rendering receipts, invoices, or any content.
MIT License
7.01k stars 774 forks source link

Add package-lock.json #80

Closed dominik-bln closed 5 years ago

dominik-bln commented 6 years ago

Add package-lock.json to ensure exact versions as recommended:

https://docs.npmjs.com/files/package-lock.json#description

kimmobrunfeldt commented 5 years ago

Hi! Thanks for the effort, this is definitely a good change. For security reasons, I'll do this package-lock.json file myself because it's really hard to review the whole file and I don't know exactly the implications of what could be done by adding a small malicious package in package-lock.json. I'm not saying you would ever do this, but it's better to be cautious. Hope you understand.

dominik-bln commented 5 years ago

Totally understandable and updating is probably not bad anyways by now.