Cookies setting fix after puppeteer update

alvarcarto / url-to-pdf-api

Web page PDF/PNG rendering done right. Self-hosted service for rendering receipts, invoices, or any content.

MIT License

7.01k stars 774 forks source link

Cookies setting fix after puppeteer update #83

Closed esvitaly closed 5 years ago

esvitaly commented 6 years ago

Page.setCookies not working anymore due to the new version of puppeteer. Now, you can't set cookies with this function if page not loaded. This pull request fixes this problem by using chrome devtools protocol session. (Issue #62)

mblarsen commented 5 years ago

Would love to see this get merged

kimmobrunfeldt commented 5 years ago

Thanks for the change!