search

alvarcarto / url-to-pdf-api

Web page PDF/PNG rendering done right. Self-hosted service for rendering receipts, invoices, or any content.
MIT License
7.01k stars 774 forks source link

Update validation.js to accept waitUntil string or Array #86

Closed coptere closed 5 years ago

coptere commented 5 years ago

This simple patch to match Puppeteer API options. (no verificication on string/valid string in array alternative) https://github.com/GoogleChrome/puppeteer/blob/v1.8.0/docs/api.md#pagegotourl-options ...waitUntil can be <string|Array>

Jameskmonger commented 5 years ago

@coptere This build is failing due to some linting issues.

coptere commented 5 years ago

@Jameskmonger eslint errors fixed.

kimmobrunfeldt commented 5 years ago

Closing due to inactivity.